Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deprecation warning to py_proto_library #19032

Merged
merged 3 commits into from
Oct 30, 2024
+3 −0
Merged

Add a deprecation warning to py_proto_library #19032

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c217a37
Add a deprecation warning to py_proto_library
mkruskal-google Oct 29, 2024
4ff3682
Remove redundant 29.0 mention
mkruskal-google Oct 30, 2024
08fc27a
Clarify warning message
mkruskal-google Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions protobuf.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,7 @@ def py_proto_library(
This is provided for backwards compatibility only. Bazel 5.3 will
introduce support for py_proto_library, which should be used instead.
"""
print("The py_proto_library macro is deprecated, switch to the rule defined by rules_python and protobuf (after 29.0).")
mkruskal-google marked this conversation as resolved.
Show resolved Hide resolved
internal_py_proto_library(*args, **kwargs)

def _source_proto_library(
Expand Down
Loading