-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(csharp/FieldMask): Support map
fields in c# FieldMask
#19673
base: main
Are you sure you want to change the base?
fix(csharp/FieldMask): Support map
fields in c# FieldMask
#19673
Conversation
FieldMask
s
FieldMask
sFieldMask
s
FieldMask
sFieldMask
s
Note for reviewers: This PR fixes two related issues
The tests might seem repetitive, but they cover all possible branches of the introduced code, that's why I split them into a separate test class. Future work:
// Valid field masks: reviews, reviews.smith, reviews.`John Smith`, reviews.`Dr. John Smith`
map<string, string> reviews = 2; Also cc @jskeet since he worked on the original implementation |
FieldMask
smap
fields in c# FieldMask
I'm not going to have time to review this PR this year, I'm afraid. |
That's ok, but would it be fine if you approved running the tests? |
Yup, will do that now. |
fixes #11989
This PR adds support to referencing keys in a map field via field masks and introduces tests that used to fail before.
related issues:
AIP: https://google.aip.dev/161#map-fields