Add cc_proto_aspect_hint to allow copts on cc_proto_library #19706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new `cc_proto_aspect_hint` allows users to specify `copts` that are then used when compiling the generated C++ code. This is a potential solution to bazelbuild/bazel#4446 In that discussion the primary concern was that if you have multiple `cc_proto_library` targets that depend on the same `proto_library` targets, if the `copts` was part of `cc_proto_library` you'd have to be sure to duplicate that to all `cc_proto_library` targets in the dependency tree. Using the relatively new `aspect_hints` functionality in bazel we can instead attach that info to the `proto_library` target itself, without adding C++ specific attributes to the `proto_library` rule.
keith
commented
Dec 18, 2024
| cc_proto_aspect_hint = rule( | ||
| implementation = _aspect_hint_impl, | ||
| attrs = { | ||
| "copts": attr.string_list(), |
There was a problem hiding this comment.
we can add any other attributes we want here, i imagine linkopts would be the next most sensible one, happy to add other useful ones in this PR, or just as use cases come up
|
@comius Could you help take a look? |
zhangskz
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new
cc_proto_aspect_hintallows users to specifycoptsthat arethen used when compiling the generated C++ code.
This is a potential solution to bazelbuild/bazel#4446
In that discussion the primary concern was that if you have multiple
cc_proto_librarytargets that depend on the sameproto_librarytargets, if the
coptswas part ofcc_proto_libraryyou'd have to besure to duplicate that to all
cc_proto_librarytargets in thedependency tree. Using the relatively new
aspect_hintsfunctionalityin bazel we can instead attach that info to the
proto_librarytargetitself, without adding C++ specific attributes to the
proto_libraryrule.