Move part of the TypeDefinedMapFieldBase implementation into MapFieldBase
#19730
+114
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_707574812
branch
from
c5cc34a to
d19f0e3
Compare
copybara-service
bot
changed the title
TypeDefinedMapFieldBase implementation into MapFieldBase
…eldBase` implemented on top of `UntypedMapBase` visitation. Reduces code duplication in large binaries. More to come in future changes. PiperOrigin-RevId: 707574812
copybara-service
bot
force-pushed
the
test_707574812
branch
from
d19f0e3 to
d8cd2e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move part of the
TypeDefinedMapFieldBaseimplementation intoMapFieldBaseimplemented on top of
UntypedMapBasevisitation.Reduces code duplication in large binaries.
More to come in future changes.