Remove reflective uses of ctype from FieldDescriptor::options(). #19756
+40
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
This has been replaced with the cpp_string_type helper on FieldDescriptor, which returns the actual behavior of the field rather than the specification. This also handles merging of ctype and string_type in edition 2023 where both are allowed. ctype will be banned from 2024 onward. PiperOrigin-RevId: 708145760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove reflective uses of ctype from FieldDescriptor::options().
This has been replaced with the cpp_string_type helper on FieldDescriptor, which returns the actual behavior of the field rather than the specification. This also handles merging of ctype and string_type in edition 2023 where both are allowed. ctype will be banned from 2024 onward.