Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block subclassing #7124

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Block subclassing #7124

merged 1 commit into from
Jan 24, 2020

Conversation

dmaclach
Copy link
Contributor

@dmaclach dmaclach commented Jan 23, 2020

Add GPB_FINAL macro to block subclassing of generated ObjC classes.

This will prevent subclassing of any of the protobuf classes generated by the compiler.
If you need to be able to do this, please let us know. You can temporarily "reenable" it by
redefining the GPB_FINAL macro.

Add GPB_FINAL macro to block subclassing of generated ObjC classes.
Copy link
Contributor

@thomasvl thomasvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit needs up updated description since we will need to tag this for inclusion in release notes.

@dmaclach
Copy link
Contributor Author

Coment added.

@thomasvl thomasvl merged commit f4a6b99 into protocolbuffers:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants