Set execute bit on files if and only if they begin with (#!). #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git only tracks the 'x' (executable) bit on each file. Prior to this CL, our files were a random mix of executable and non-executable. This change imposes some order by making files executable if and only if they have shebang (#!) lines at the beginning. We don't have any executable binaries checked into the repo, so we shouldn't need to worry about that case.
acozzette
approved these changes
Apr 1, 2020
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
…olbuffers#7347) * Set execute bit on files if and only if they begin with (#!). Git only tracks the 'x' (executable) bit on each file. Prior to this CL, our files were a random mix of executable and non-executable. This change imposes some order by making files executable if and only if they have shebang (#!) lines at the beginning. We don't have any executable binaries checked into the repo, so we shouldn't need to worry about that case. * Added fix_permissions.sh script to set +x iff a file begins with (#!).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git only tracks the 'x' (executable) bit on each file. Prior to this
CL, our files were a random mix of executable and non-executable.
This change imposes some order by making files executable if and only
if they have shebang (#!) lines at the beginning.
We don't have any executable binaries checked into the repo, so
we shouldn't need to worry about that case.