Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated PHP upb, and utf8_range for Ruby/PHP #9585

Merged
merged 5 commits into from
Mar 5, 2022
Merged

Updated PHP upb, and utf8_range for Ruby/PHP #9585

merged 5 commits into from
Mar 5, 2022

Conversation

haberman
Copy link
Member

@haberman haberman commented Mar 4, 2022

No description provided.

@haberman
Updated PHP to the new version of upb.
e37f6b5 
This is a large change, as the upb API surface has been
renamed to follow Google style more closely.
@haberman
Fixed utf8_range.
02f2e67
@haberman
Updated Ruby for new utf8_range.
1256182
@haberman haberman requested a review from acozzette March 4, 2022 21:25
@acozzette
Copy link
Member

It looks like codespell detected a couple of spelling errors:

Error: ./php/ext/google/protobuf/php-upb.c:5544: contigous ==> contiguous
Error: ./php/ext/google/protobuf/php-upb.c:5545: offets ==> offsets, offers```

@haberman haberman merged commit 349d74d into protocolbuffers:master Mar 5, 2022
@acozzette acozzette mentioned this pull request Mar 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acozzette acozzette acozzette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haberman @acozzette @protobuf-kokoro