Skip to content

Commit

Permalink
Set allow_empty = True on file globs
Browse files Browse the repository at this point in the history
This allows everything to build successfully with the
`--incompatible_disallow_empty_glob` flag, which will eventually by
enabled by default. I believe these particular globs are expected to be
empty if Ruby is not installed locally.
  • Loading branch information
acozzette authored and JasonLunn committed Oct 11, 2024
1 parent f4de0fb commit e9db423
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ruby/private/toolchains/ruby_runtime.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@ sh_binary(
cc_import(
name = "libruby",
hdrs = glob({hdrs}),
hdrs = glob({hdrs}, allow_empty = True),
shared_library = {shared_library},
static_library = {static_library},
)
cc_library(
name = "headers",
hdrs = glob({hdrs}),
hdrs = glob({hdrs}, allow_empty = True),
includes = {includes},
)
Expand Down

0 comments on commit e9db423

Please sign in to comment.