stop requiring extension fields to have a synthetic oneof #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsalo
approved these changes
Dec 12, 2022
haines
added a commit
to haines/cerbos-sdk-ruby
that referenced
this pull request
Jun 10, 2024
Earlier versions fail to load the `protovalidate` extension field descriptors with "field with proto3_optional was not in a oneof (buf.validate.priv.field)". protocolbuffers/upb#1034 Signed-off-by: Andrew Haines <haines@cerbos.dev>
haines
added a commit
to haines/cerbos-sdk-ruby
that referenced
this pull request
Jun 10, 2024
Earlier versions fail to load the `protovalidate` extension field descriptors with "field with proto3_optional was not in a oneof (buf.validate.priv.field)". protocolbuffers/upb#1034 Signed-off-by: Andrew Haines <haines@cerbos.dev>
haines
added a commit
to cerbos/cerbos-sdk-ruby
that referenced
this pull request
Jun 10, 2024
* Test against all supported dependency versions * Add explicit dependency on `google-protobuf` * Increase `google-protobuf` version requirement to 3.21.12+ Earlier versions fail to load the `protovalidate` extension field descriptors with "field with proto3_optional was not in a oneof (buf.validate.priv.field)". protocolbuffers/upb#1034 Signed-off-by: Andrew Haines <haines@cerbos.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/protocolbuffers/upb/issues/812
PiperOrigin-RevId: 478527073
This cherry-pick is to address users on the 21.x branch who are running into this issue: