upb CopyFrom the default empty message should just clear instead of deep copy #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_559643466
branch
2 times, most recently
from
e76d827
to
bff2eb9
Compare
…eep copy from memory fix protocolbuffers/protobuf#13485 PiperOrigin-RevId: 559870202
copybara-service
bot
force-pushed
the
test_559643466
branch
from
bff2eb9
to
57636ce
Compare
arcra
added a commit
to tensorflow/tensorboard
that referenced
this pull request
Oct 23, 2023
protocolbuffers/protobuf#13485 was fixed with protocolbuffers/upb#1514, so this shouldn't be an issue anymore. If CI passes successfully with this change, then it should be fine to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upb CopyFrom the default empty message should just clear instead of deep copy
from memory
fix protocolbuffers/protobuf#13485