Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patter that does not glob anything #745

Merged
merged 2 commits into from
Sep 10, 2022

Conversation

limdor
Copy link
Contributor

@limdor limdor commented Aug 24, 2022

This pattern does not glob anything because inside the upbc folder there is a BUILD file.
Removing this allows to build upb with the flag incompatible_disallow_empty_glob

Note: This is needed in order to build Bazel with the flag flipped.

This pattern does not glob anything because inside the upbc folder there is a BUILD file.
Removing this allows to build upb with the flag incompatible_disallow_empty_glob
Copy link
Member

@ericsalo ericsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an innocent enough change but many of the tests are now breaking.

@limdor
Copy link
Contributor Author

limdor commented Aug 26, 2022

This seems like an innocent enough change but many of the tests are now breaking.

Can you point me to the log of a failing test? The ones here in github they seem to fail but to me looks like something unrelated. Or do you think that is related to the change?

Error: google-github-actions/auth failed with: retry function failed with 0 attempts: the GitHub Action workflow must specify exactly one of "workload_identity_provider" or "credentials_json"! If you are specifying input values via GitHub secrets, ensure the secret is being injected into the environment. By default, secrets are not passed to workflows triggered from forks, including Dependabot.

Another option is to add the allow_empty=True, but it would be good to investigate why the tests are failing, I cannot see how this could change behaviour.

@ericsalo
Copy link
Member

The cause of the failures has been identified. Once we have fixed them on our end we should be able to proceed with this PR. Unfortunately most of the team will be away on an offsite this coming week so it may be a little while before we can get to it.

@limdor
Copy link
Contributor Author

limdor commented Aug 28, 2022

Ok, thanks for the update. The goal would be before the cut for Bazel 6 on September 12th to have this merged and Bazel updated with a version that contains this change.

@limdor
Copy link
Contributor Author

limdor commented Sep 7, 2022

@ericsalo any updates on this?

@copybara-service copybara-service bot merged commit 8ab26d4 into protocolbuffers:main Sep 10, 2022
@limdor
Copy link
Contributor Author

limdor commented Sep 12, 2022

@ericsalo would it be possible to bring this change to the 21.x branch? What would be the process for that?

@fowles
Copy link
Contributor

fowles commented Sep 12, 2022

a PR with a cherrypick would suffice

@limdor
Copy link
Contributor Author

limdor commented Sep 12, 2022

Thanks @fowles, I created the PR in #780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants