Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(membership): add DaniPopes from Reth #159

Merged
merged 1 commit into from
Apr 26, 2024
Merged

feat(membership): add DaniPopes from Reth #159

merged 1 commit into from
Apr 26, 2024

Conversation

shekhirin
Copy link
Contributor

@shekhirin shekhirin commented Apr 17, 2024 •
edited
Loading

  • Name, GitHub: @DaniPopes
  • Team: Reth
  • Short summary of their work / eligibility:
  • Start date of relevant projects: August 2023
  • Proposed weight: Full (1.0)

I also sorted the list of Reth team member names

@shekhirin shekhirin changed the title feat(membership): add DaniPopes feat(membership): add DaniPopes from Reth Apr 17, 2024
rkrasiuk
rkrasiuk approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@tvanepps
Copy link
Member

love to see reth coming into full strength!

however, i dont think the alloy and foundry work shouldn't be listed as these target the dev tooling layer, not the PG defined core protocol eligible projects.

If you can, please:

  • remove alloy and foundry from the PR so this is an accurate reference for future nominations
  • adjust (if necessary) the proposed weight & start date to only consider ongoing revm and reth contributions

@shekhirin
Copy link
Contributor Author

@tvanepps updated the PR description, thanks for the feedback.

@tvanepps tvanepps merged commit f8b02d9 into protocolguild:main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@mattsse mattsse mattsse approved these changes

@gakonst gakonst gakonst approved these changes

@rakita rakita rakita approved these changes

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
add member processed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@shekhirin @tvanepps @Rjected @rakita @gakonst @mattsse @rkrasiuk @emhane @cheeky-gorilla