Liquidity mining

[kadenzipfel]

Closes: #1822
Closes: #1824
Closes: #1832
Closes: #1833
Closes: #1834

Testing (rinkeby):

Here are the markets that can be used for testing:

• http://localhost:3000/#/0x308fb252588acbdb52c28a39089b9c2a98d4218e
• http://localhost:3000/#/0x8c2df9156eed194bc8e404f1d56e0d8e513c4897

New markets for testing:

• http://localhost:3000/#/0xe253df8dfc512b938d09ede69406f68185e13875
• http://localhost:3000/#/0x6953e12adaa3c121b86f2522510c676c5427bbcc

Test cases:

• Successful market creation (Share tx so I can verify that staking contract was properly deployed)
  • Categorical
  • Scalar
• Categorical market (see markets above)
  • Buy
  • Sell
  • Deposit
  • Claim rewards
  • Withdraw
  • Bond
  • Redeem
• Scalar market (see markets above)
  • Buy
  • Sell
  • Deposit
  • Claim rewards
  • Withdraw
  • Bond
  • Redeem

[pimato]

I couldn`t wait to check this important PR out :) . It looks like you are using an svg prepared for the market details view which does not work well with the markets overview listItem rewards icon (borders are too thin):

I´ve created a specific rewards icon with 16x16px so the borders are look like they supposed to:
rewards.svg.zip

[pimato]

Hey Kaden, just checked and it seems that your test market has no active rewards program:

[kadenzipfel]

@kadenzipfel tried out the new markets and was getting one of those 'transaction will revert' cpk errors when trying to claim - To reproduce you can deposit some amount and then click and cancel 'Claim Rewards' until you get an error.

I think this might be similar to the sell issues we had where our off-chain calcs were a little bit high. In withdrawRewards if I add:

const totalRewardsAmount = claimableRewards[i].add(unclaimedRewards).mul(99999999).div(100000000)

It seems like the error goes away. What do you think?

I haven't been able to reproduce, but there shouldn't be room for a calculation issue since we're fetching data directly from the chain. To clarify, you reproduce by clicking claim then rejecting the tx and repeating until you get the error? Does it work if you wait a few seconds and try again?

[hexyls]

mmmmm true, all data directly fetched from the chain 🤔 gotta see if I can reproduce again today but yeah what you wrote is how I was getting the error yesterday

edit: I can't figure out why this is happening 😩 more details: I'm using this market and I have 29.70 DAI out of the total 30.69 DAI liquidity. When I click claim rewards I get a cpk error... if I add await new Promise(r => setTimeout(r, 2000)) inside withdrawRewards the error goes away so must be some sort of timing thing...

[Mi-Lan]

Was just testing it! Claiming and depositing and withdrawing works good fore me. I found one issue when I claim rewards immediately after Im able to claim it again. Is this some issue with dust value or?
https://user-images.githubusercontent.com/33226956/130783970-4ae1e4e3-3a76-401a-9741-e03013087bad.mov

[pimato]

looks like there is an issue with showing the current APY with this market:
http://localhost:3000/#/0xe253df8dfc512b938d09ede69406f68185e13875

[pimato]

can we reduce the decimals here to just two:

[pimato]

I don`t think it is an issue with the 15 seconds block time as @kadenzipfel is expecting. I tried to claim rewards 4 minutes after my deposit:

nue-2.mov

[Mi-Lan]

I don`t think it is an issue with the 15 seconds block time as @kadenzipfel is expecting. I tried to claim rewards 4 minutes after my deposit:

nue-2.mov

Im able to reproduce it but only on categorical http://localhost:3001/#/0xe253df8dfc512b938d09ede69406f68185e13875/pool

[kadenzipfel]

@hexyls @Mi-Lan @pimato I still have not been able to reproduce the bug but I have implemented hexyls' suggestion to reduce the total claim amount slightly. Hopefully this should generally prevent issues, but I think using the cpk for this kind of action will never be quite perfect, yet as long as the user can still claim after trying again I think it's ok to ignore

[hexyls]

@kadenzipfel yeah no idea why but that does appear to resolve the issue 👍 curious if the problem goes away for anyone else

[pimato]

Test cases:

• Successful market creation (Share tx so I can verify that staking contract was properly deployed)
  • Categorical: http://localhost:3000/#/0x376feadb234ca8cd003e865ba0fa9e6763be9cdd
  • Scalar: http://localhost:3000/#/0x4804e8ef8b827e56b90f0491a922583dc68441b6
• Categorical market (see markets above)
  • Buy: https://rinkeby.etherscan.io/tx/0xe4d1cdccea070d162d01a3acf01ba629879640c99ede56863bcbbad0225a3de5
  • Sell: https://rinkeby.etherscan.io/tx/0xd9646549b38210ba4d1dfb304080326213f49ca3daebd75ed6f0fc6da69a4568
  • Deposit: https://rinkeby.etherscan.io/tx/0xbd17b41304a97b986d2b2a88d2117aa5ea02371e1a297785a94eb3ceb26b4635
  • Claim rewards: https://rinkeby.etherscan.io/tx/0x16e244be895eca956edee545b27c7d333133b61f1a8e653ac0ff616d543a2658
  • Withdraw: https://rinkeby.etherscan.io/tx/0xeb42ea7a263cb51d508597f67246758f0740a76b171a380f8b5523eada1a7099
  • Bond: https://rinkeby.etherscan.io/tx/0x461474629b61e6505de01dfdc249a7a182a75a4295a78ad57c0894b5560e1f05
  • Redeem: https://rinkeby.etherscan.io/tx/0x91ab5b0a647efe6b754b3e2bd62d5be529a87d89f36b3a8df2ef5e36d0373818
• Scalar market (see markets above)
  • Buy: https://rinkeby.etherscan.io/tx/0xcf98995d7fb7d633b8d1d3a0999d6c50fff2147ad25473d307439266e20cab25
  • Sell: https://rinkeby.etherscan.io/tx/0xb6f297659ff1d56e816a9cc4271a637b3a59a350f9588c1b9384ba6434f49e98
  • Deposit: https://rinkeby.etherscan.io/tx/0x7cbd66c37fe22fcd7596e11bf5b98b4a4524f5f9aa92b9a0cbf7e80784881c80
  • Claim rewards: https://rinkeby.etherscan.io/tx/0xd2f7f0d4e4cde049d0c19a6e12877fbbb23bb9a1d802ef7bef26352e76846b39
  • Withdraw: https://rinkeby.etherscan.io/tx/0x7cbd66c37fe22fcd7596e11bf5b98b4a4524f5f9aa92b9a0cbf7e80784881c80
  • Bond: https://rinkeby.etherscan.io/tx/0x6fa8a39fd2cb294184a49fde03f71c55c27bb36b28337d6ad70650d569ee7bfc
  • Redeem: https://rinkeby.etherscan.io/tx/0x84ce45b0a1a93f8560be230e12130af9bbb104ef8b5555cd6f2ae5405e7993f3

[Mi-Lan]

Test cases:

• Successful market creation (Share tx so I can verify that staking contract was properly deployed)
  • Categorical
    https://rinkeby.etherscan.io/tx/0x0a0ddc8791691e21cfdab8742d3f1f5f83d79bdf79ca8a60d0d8a15f1768a9fa
  • Scalar
    http://localhost:3001/#/0x2efeee551479bc30a7b1a64312791658f24c18cb/buy
• Categorical market (see markets above)
  • Buy
  • Sell
  • Deposit
  • Claim rewards
  • Withdraw
  • Bond
  • Redeem
• Scalar market (see markets above)
  • Buy
  • Sell
  • Deposit
  • Claim rewards
  • Withdraw
  • Bond
  • Redeem

[kadenzipfel]

New, short term markets for testing:

• http://localhost:3000/#/0x0a29d49ecca02a04efbc5a6cd38060225e245831
• http://localhost:3000/#/0xb3b6208b3a8e09b3459948c30f0e512ed4d6bb8d

Resolution date is Sunday at 12:00am UTC, so staking rewards end Saturday at 12:00am UTC so make sure to test before then

[hexyls]

• Categorical market
  • Buy
  • Sell
  • Deposit
  • Claim rewards
  • Withdraw
  • Bond
  • Redeem
• Scalar market (see markets above)
  • Buy
  • Sell
  • Deposit
  • Claim rewards - mmm no rewards were showing up for me on http://localhost:3000/#/0xb3b6208b3a8e09b3459948c30f0e512ed4d6bb8d/pool - can anyone confirm?
  • Withdraw
  • Bond
  • Redeem

[pimato]

Works!