-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new my markets filter, reconfigure existing filters for greater maintainability #2146
Conversation
…s for greater maintainability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When trying to filter "My Markets" + "Ended recently" + "Scalar markets" I have 1 categorical market in the list, can you reproduce?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we should probably keep track of the previously picked/default sort type when going back from market details view to market overview:
Bildschirmaufnahme.2021-08-02.um.12.31.04.mov
When trying to filter "My Markets" + "Ended recently" + "Scalar markets" I have 1 categorical market in the list, can you reproduce?
can reproduce:
Bildschirmaufnahme.2021-08-02.um.12.34.28.mov
Yeah, sadly we can't query by market type yet for my markets, but I've added an subgraph issue for how to make this possible: protofire/omen-subgraph#184 |
I've set it to keep the default sort type when we go back now. It can also be set to go to the previously picked filter, but would require a little extra work... Should I make an issue for that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
I´ve created an issue for it: #2150 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kadenzipfel Good job man! Tested it out works as it should and went through the code! Nice addition with the new ended recently filter. Made just one small comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the filters work smoothly, great job and great addition on the filter under My Markets 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kadenzipfel GJ!
Closes: #2017
Testing: