avoid counting immutable for the max-state-count rule

protofire · Oct 28, 2020 · a36546b · a36546b
1 parent 445bf32
commit a36546b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/rules/best-practises/max-states-count.js b/lib/rules/best-practises/max-states-count.js
@@ -55,7 +55,9 @@ class MaxStatesCountChecker extends BaseChecker {
   ContractDefinition(node) {
     const countOfVars = _(node.subNodes)
       .filter(({ type }) => type === 'StateVariableDeclaration')
-      .flatMap(subNode => subNode.variables.filter(variable => !variable.isDeclaredConst))
+      .flatMap(({ variables }) =>
+        variables.filter(({ isDeclaredConst, isImmutable }) => !isDeclaredConst && !isImmutable)
+      )
       .value().length
 
     if (countOfVars > this.maxStatesCount) {

diff --git a/test/rules/best-practises/max-states-count.js b/test/rules/best-practises/max-states-count.js
@@ -45,4 +45,18 @@ describe('Linter - max-states-count', () => {
 
     assertNoErrors(report)
   })
+
+  it('should not count immutable variables', () => {
+    const code = contractWith(`
+      uint public immutable a;
+      uint public b;
+      uint public c;
+
+      function f() {}
+    `)
+
+    const report = linter.processStr(code, { rules: { 'max-states-count': ['error', 2] } })
+
+    assertNoErrors(report)
+  })
 })