Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'private-vars-leading-underscore' rule #185

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

fvictorio
Copy link
Contributor

Closes #90.

Private and internal state variables should have a leading underscore in their names. Public state variables should not. The default visibility is internal.

Private and internal functions should have a leading underscore. Public and external functions should not. The default visibility is public.

For functions in libraries, the rules are the same except internal functions shouldn't have a leading underscore (only private functions).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 96.073% when pulling 799b454 on add-leading-underscores-rule into 265d95f on 3.0.

@fernandomg fernandomg merged commit 5258df7 into 3.0 Jan 31, 2020
@fernandomg fernandomg deleted the add-leading-underscores-rule branch January 31, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants