Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sarif formatter #530

Merged
merged 3 commits into from
Dec 21, 2023
Merged

feat: add sarif formatter #530

merged 3 commits into from
Dec 21, 2023

Conversation

eshaan7
Copy link
Contributor

@eshaan7 eshaan7 commented Dec 21, 2023

Adds a sarif formatter to output SARIF report. Implementation based on @microsoft/eslint-formatter-sarif.

@dbale-altoros
Copy link
Collaborator

@eshaan7 Thanks a lot for your contribution. We really appreciate and will be putting this feature in next version.

Please add necessary changes for the CI to succeed
Remove the .only from the describe on the E2E tests as well

@dbale-altoros dbale-altoros self-requested a review December 21, 2023 11:20
@dbale-altoros dbale-altoros added the awaiting user feedback awaiting user feedback label Dec 21, 2023
@eshaan7
Copy link
Contributor Author

eshaan7 commented Dec 21, 2023

Made the changes, @dbale-altoros. Thank you!

@dbale-altoros
Copy link
Collaborator

@eshaan7 THANK YOU!
merged to develop

we will mention your contribution in next version log file
Thanks!

@dbale-altoros dbale-altoros merged commit 1a9fe48 into protofire:develop Dec 21, 2023
10 checks passed
@dbale-altoros dbale-altoros removed the awaiting user feedback awaiting user feedback label Dec 21, 2023
@dbale-altoros
Copy link
Collaborator

@eshaan7
You can join our discord server to get news on futures versions
https://discord.gg/4TYGq3zpjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants