Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new feature --ignore-path option #58

Merged
merged 11 commits into from
Sep 6, 2018

Conversation

florblue
Copy link
Contributor

@florblue florblue commented Sep 5, 2018

Description

It was added --ignore-path [file-name] option: allows to specify path of ignore file, and include file validation.

  • This change was motivated by checking basics features that esLint gives.
  • It requires a documentation update
  • Existing unit tests pass locally with my changes

@coveralls
Copy link

coveralls commented Sep 5, 2018

Coverage Status

Coverage remained the same at 99.657% when pulling 0cacb5b on Cambalab:add-contribution-ignore-path into 2263ccb on protofire:master.

@fvictorio
Copy link
Contributor

This looks good, but there are merge conflicts.

@florblue
Copy link
Contributor Author

florblue commented Sep 5, 2018

Perfect, I just resolved the merge conflicts.

@fvictorio fvictorio merged commit 3eeb38a into protofire:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants