Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fountain gets lake label #279

Closed
wipfli opened this issue Jul 30, 2024 · 6 comments
Closed

Fountain gets lake label #279

wipfli opened this issue Jul 30, 2024 · 6 comments

Comments

@wipfli
Copy link
Collaborator

wipfli commented Jul 30, 2024

The "Rebekkabrunnen" (Rebecca Fountain) in Zürich gets what looks like a lake label.

https://maps.protomaps.com/#map=19.06/47.3669738/8.53999&theme=light&tiles=https://build.protomaps.com/20240730.pmtiles

Screenshot_20240730-193721

I think that should be a POI instead...

@wipfli
Copy link
Collaborator Author

wipfli commented Jul 30, 2024

https://www.openstreetmap.org/way/667718519

It has natural=water and amenity=fountain

@bdon
Copy link
Member

bdon commented Aug 5, 2024

Following https://tilezen.readthedocs.io/en/latest/layers/#water-kind-values let's change kind to fountain instead of water

bdon added a commit that referenced this issue Aug 5, 2024
bdon added a commit that referenced this issue Aug 5, 2024
* change amenity=fountain in water to kind=fountain [#279]

* tiles 3.7.1; update CHANGELOG [#279]
@bdon
Copy link
Member

bdon commented Aug 5, 2024

Resolved by #281

@bdon bdon closed this as completed Aug 5, 2024
@wipfli
Copy link
Collaborator Author

wipfli commented Aug 8, 2024

Thanks for the proposed fix @bdon. Unfortunately, it looks like the lake label on this fountain is still present:

image

https://maps.protomaps.com/#map=19.61/47.3670034/8.54007&theme=light&tiles=https://build.protomaps.com/20240808.pmtiles

@bdon
Copy link
Member

bdon commented Aug 12, 2024

Missed this because the label is in the physical_point layer which we are working on deprecating...

@nvkelso nvkelso reopened this Aug 12, 2024
@bdon bdon closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants