Skip to content

chore: improved Dockerfile to utilize cached layers #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025

Conversation

mxzinke
Copy link
Contributor

@mxzinke mxzinke commented Apr 28, 2025

It was kind of annoying to me, doing a complete refetch of the dependencies on each build within docker.

It was kind of annoying to me, doing a complete refetch of the dependencies on each build within docker.
@wipfli
Copy link
Collaborator

wipfli commented Apr 29, 2025

@bdon do we actually want to keep maintaining this dockerfile?

@wipfli
Copy link
Collaborator

wipfli commented Apr 29, 2025

Thanks for opening the pull request in any case @mxzinke. I just never used that file before and maybe we could abandon docker for the build altogether...

@mxzinke
Copy link
Contributor Author

mxzinke commented Apr 29, 2025

I am a big fan of Docker, since it makes it easier for me to jump between projects without messing around with dependencies.

In my opinion, it's a must-have for open-source project and if there were no before, I did not even look deeper into the project since no JDK whatsoever is installed on my computer. Basically, for everyone coming to the project, they can go build the docker image and take a test run.

Copy link

sonarqubecloud bot commented May 4, 2025

@bdon
Copy link
Member

bdon commented May 4, 2025

Thanks, this is a nice improvement but it still looks like it contacts the repository at mvn clean package step without the -o flag? (I couldn't get that to work)

I think we should have a Dockerfile for the audience that prefers that, though to make this a good experience we would also need to provide some instructions around mounting the data directory volume from the host so it doesn't re-download sources every time.

@bdon bdon merged commit 2bff3cd into protomaps:main May 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants