Change capitalization of ETag header to align with conventions [#137] (…

…#140)
protomaps · Feb 13, 2024 · 82257ce · 82257ce
1 parent 800168b
commit 82257ce
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/pmtiles/server.go b/pmtiles/server.go
@@ -296,7 +296,7 @@ func (server *Server) getTileJSON(ctx context.Context, httpHeaders map[string]st
 	}
 
 	httpHeaders["Content-Type"] = "application/json"
-	httpHeaders["Etag"] = generateEtag(tilejsonBytes)
+	httpHeaders["ETag"] = generateEtag(tilejsonBytes)
 
 	return 200, httpHeaders, tilejsonBytes
 }
@@ -313,7 +313,7 @@ func (server *Server) getMetadata(ctx context.Context, httpHeaders map[string]st
 	}
 
 	httpHeaders["Content-Type"] = "application/json"
-	httpHeaders["Etag"] = generateEtag(metadataBytes)
+	httpHeaders["ETag"] = generateEtag(metadataBytes)
 	return 200, httpHeaders, metadataBytes
 }
 func (server *Server) getTile(ctx context.Context, httpHeaders map[string]string, name string, z uint8, x uint32, y uint32, ext string) (int, map[string]string, []byte) {
@@ -396,7 +396,7 @@ func (server *Server) getTileAttempt(ctx context.Context, httpHeaders map[string
 				return 500, httpHeaders, []byte("I/O error"), ""
 			}
 
-			httpHeaders["Etag"] = generateEtag(b)
+			httpHeaders["ETag"] = generateEtag(b)
 			if headerVal, ok := headerContentType(header); ok {
 				httpHeaders["Content-Type"] = headerVal
 			}

diff --git a/pmtiles/server_test.go b/pmtiles/server_test.go
@@ -401,16 +401,16 @@ func TestEtagResponsesFromTile(t *testing.T) {
 	assert.Equal(t, 204, statusCode)
 
 	// 204's have no etag
-	assert.Equal(t, "", headers311v1["Etag"])
-	assert.Equal(t, "", headers311v2["Etag"])
+	assert.Equal(t, "", headers311v1["ETag"])
+	assert.Equal(t, "", headers311v2["ETag"])
 
 	// 000 and 311 didn't change
-	assert.Equal(t, headers000v1["Etag"], headers000v2["Etag"])
+	assert.Equal(t, headers000v1["ETag"], headers000v2["ETag"])
 
 	// 412 did change
-	assert.NotEqual(t, headers412v1["Etag"], headers412v2["Etag"])
+	assert.NotEqual(t, headers412v1["ETag"], headers412v2["ETag"])
 
 	// all are different
-	assert.NotEqual(t, headers000v1["Etag"], headers311v1["Etag"])
-	assert.NotEqual(t, headers000v1["Etag"], headers412v1["Etag"])
+	assert.NotEqual(t, headers000v1["ETag"], headers311v1["ETag"])
+	assert.NotEqual(t, headers000v1["ETag"], headers412v1["ETag"])
 }