Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Docker image to convert #171

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Allow Docker image to convert #171

merged 2 commits into from
Jun 11, 2024

Conversation

zstadler
Copy link
Contributor

Add a /tmp directory to the image by copying it from the builder.

Resolve #170

@zstadler
Allow Docker image to convert
9490de2 
Add a `/tmp` directory to the image by copying it from the builder.

Resolve protomaps#170
@zstadler zstadler marked this pull request as draft June 10, 2024 08:22
@zstadler
Copy link
Contributor Author

zstadler commented Jun 10, 2024 •
edited
Loading

It turns out that adding a /tmp directory, with the appropriate permissions, to the scratch image is not an easy task.
See How to add a empty directory to a scratch image with specific permissions? on reddit.

@zstadler zstadler marked this pull request as ready for review June 10, 2024 11:25
@bdon bdon mentioned this pull request Jun 10, 2024
Closed
@bdon bdon merged commit 0457789 into protomaps:main Jun 11, 2024
3 of 4 checks passed
@bdon bdon mentioned this pull request Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker image cannot convert
2 participants
@zstadler @bdon