This repository has been archived by the owner on Nov 16, 2024. It is now read-only.
Specify using UTF-16 Little endian #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're writing bytes using the LittleEndian mode, we should rather specify we're using UTF-16LE rather than let the platform randomly decide which one is the correct one. This also fixes protoncr#60
|
Ahh the M1 chips are big endian and by default set_encoding must be using the system endianness |
|
Thanks for this! |
The M1s are little endian, but for some reason Crystal is choosing the wrong default for the UTF-16, I'll see where the discussion lands in the bug I opened in the compiler. Thanks for merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're writing bytes using the LittleEndian mode, we should rather specify we're using UTF-16LE rather than let the platform randomly decide which one is the correct one.
This also fixes #60