Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Targeting solidity compiler v0.4.18 and updated to silence warnings #23

Merged
merged 22 commits into from
Nov 30, 2017
Merged

Targeting solidity compiler v0.4.18 and updated to silence warnings #23

merged 22 commits into from
Nov 30, 2017

Commits on Nov 20, 2017

  1. odd issue with atom editor, removing and re-inserting multiple lines,… 

    … to be ignored
    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    93638f5 View commit details
    Browse the repository at this point in the history

  2. all if throw's converted to requires

    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    8d16ad6 View commit details
    Browse the repository at this point in the history

  3. public modifiers explicitly added to all default public methods

    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    b2d21ac View commit details
    Browse the repository at this point in the history

  4. sha3 converted to keccak256

    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    4cef9b8 View commit details
    Browse the repository at this point in the history

  5. public modifier added to OraclizeAddrResolverI getAddress method

    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    dab6ac9 View commit details
    Browse the repository at this point in the history

  6. var converted to uint256

    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    6551cbc View commit details
    Browse the repository at this point in the history

  7. added state mutability modifiers where applicable

    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    b6c0fbd View commit details
    Browse the repository at this point in the history

  8. explicit conversion of decimal to byte data type

    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    5cb8617 View commit details
    Browse the repository at this point in the history

  9. remove unused networkID param from set network

    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    430fdf2 View commit details
    Browse the repository at this point in the history

  10. setNetwork unused param removed on method call and callback method ma… 

    …de explicitly abstract
    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    82cabde View commit details
    Browse the repository at this point in the history

  11. added setNetwork method with input param in order to maintain backwar… 

    …ds compatibility
    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    0394647 View commit details
    Browse the repository at this point in the history

  12. updated compiler version to 0.4.18

    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    3d1b197 View commit details
    Browse the repository at this point in the history

  13. added placeholder __callback method to maintain backwards compatibility

    @AdamJLemmon
    AdamJLemmon committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    6a3f405 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2017

  1. moved updated api targeting 0.4.18 to a new 0.5 api version and rever… 

    …ted 0.4 file back to 0.4 compatible version
    @AdamJLemmon
    AdamJLemmon committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    ef27f51 View commit details
    Browse the repository at this point in the history

  2. updated initial comment specifying the use of this api and to revert … 

    …to 0.4 or pre 0.4 where necessary
    @AdamJLemmon
    AdamJLemmon committed Nov 24, 2017
    Configuration menu
    Copy the full SHA
    db63f33 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2017

  1. updated oraclizeI visibility modifiers to match the connector

    @AdamJLemmon
    AdamJLemmon committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    1ae72c5 View commit details
    Browse the repository at this point in the history

  2. return added before variable use to silence warnings

    @AdamJLemmon
    AdamJLemmon committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    62bc14c View commit details
    Browse the repository at this point in the history

  3. removed methods from oraclizeI that are no longer present in the conn… 

    …ector
    @AdamJLemmon
    AdamJLemmon committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    d50ea57 View commit details
    Browse the repository at this point in the history

  4. check changed to bytes > 0 not != 0

    @AdamJLemmon
    AdamJLemmon committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    f5c4bba View commit details
    Browse the repository at this point in the history

  5. assert used in place of require in order to burn all gas and not rewa… 

    …rd oraclize with the remaining
    @AdamJLemmon
    AdamJLemmon committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    d6a3c7e View commit details
    Browse the repository at this point in the history

  6. set config and use coupon removed entirely from api as not longer sup… 

    …ported within the connector
    @AdamJLemmon
    AdamJLemmon committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    023914a View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2017

  1. assert changed back to require in order to save the gas when exceptio… 

    …n raised
    @AdamJLemmon
    AdamJLemmon committed Nov 29, 2017
    Configuration menu
    Copy the full SHA
    0ada9bd View commit details
    Browse the repository at this point in the history