Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add goerli OAR #83

Merged
merged 1 commit into from
Mar 25, 2019
Merged

feat: add goerli OAR #83

merged 1 commit into from
Mar 25, 2019

Conversation

D-Nice
Copy link
Contributor

@D-Nice D-Nice commented Mar 22, 2019

adds Goerli testnet support by including its OAR in the API

@D-Nice D-Nice self-assigned this Mar 22, 2019
adds Goerli testnet support by including its OAR in the API
Copy link
Collaborator

@gskapka gskapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me - appreciate the eye for detail re formatting!

@@ -342,6 +342,11 @@ contract usingOraclize {
oraclize_setNetworkName("eth_rinkeby");
return true;
}
if (getCodeSize(0xa2998EFD205FB9D4B4963aFb70778D6354ad3A41)>0){ //goerli testnet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the consistency with the extant formatting, even though I hate the extant formatting!

Copy link

@riccardopersiani riccardopersiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@D-Nice D-Nice merged commit 16cff4a into master Mar 25, 2019
@gskapka gskapka deleted the feat/goerli branch March 25, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants