Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebrand to provable #90

Merged
merged 14 commits into from
Jun 24, 2019
Merged

rebrand to provable #90

merged 14 commits into from
Jun 24, 2019

Conversation

D-Nice
Copy link
Contributor

@D-Nice D-Nice commented Jun 16, 2019

check 987acad & 4eeb809

for rebrand diffs

@D-Nice D-Nice requested a review from gskapka June 16, 2019 21:32
@D-Nice D-Nice self-assigned this Jun 16, 2019
@D-Nice
Copy link
Contributor Author

D-Nice commented Jun 16, 2019

to keep OAR acronym, used OracleAddrResolver name for former OraclizeAddrResolver contract name, so it is at least more general and not tied to former name to avoid brand confusion.

@D-Nice
Copy link
Contributor Author

D-Nice commented Jun 17, 2019

comings months typo in README

@D-Nice D-Nice marked this pull request as ready for review June 24, 2019 14:58
Copy link
Collaborator

@gskapka gskapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have pushed a commit fixing the typo you mentioned in the README and tweaking the wording in the deprecation bit.

But yeah, LGTM. Can only find Oraclize in 0.5 where it should be, ie, the previous years' copywrite lines.

@D-Nice
Copy link
Contributor Author

D-Nice commented Jun 24, 2019

thanks for the fix commit!

@D-Nice D-Nice merged commit ce80fb7 into master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants