Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added factory for read data #47

Merged
merged 14 commits into from
Apr 26, 2023
Merged

Added factory for read data #47

merged 14 commits into from
Apr 26, 2023

Conversation

a-chumagin
Copy link
Collaborator

  • Updates the prepare-unit-tests target in the Makefile to install the moto package in addition to the pytest package.
  • Adds a new Python module data_source_factory.py in the functions/data_test directory.
  • Defines an abstract class DataSource and several concrete subclasses in data_source_factory.py, each representing a type of data source.
  • Defines a DataSourceFactory class in data_source_factory.py that creates instances of these subclasses based on the input parameters passed to it.
  • Defines a read method for each data source subclass in data_source_factory.py, which reads data from the corresponding source and returns it as a Pandas DataFrame.
  • Defines a variable ENV in data_source_factory.py that stores the environment name read from the ENVIRONMENT environment variable.
  • unit tests

refactoring

feat: added tests for athena
@a-chumagin a-chumagin merged commit 51ad627 into main Apr 26, 2023
@a-chumagin a-chumagin deleted the factory-pattern branch April 26, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants