-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added factory for read data #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
a-chumagin
commented
Mar 27, 2023
- Updates the prepare-unit-tests target in the Makefile to install the moto package in addition to the pytest package.
- Adds a new Python module data_source_factory.py in the functions/data_test directory.
- Defines an abstract class DataSource and several concrete subclasses in data_source_factory.py, each representing a type of data source.
- Defines a DataSourceFactory class in data_source_factory.py that creates instances of these subclasses based on the input parameters passed to it.
- Defines a read method for each data source subclass in data_source_factory.py, which reads data from the corresponding source and returns it as a Pandas DataFrame.
- Defines a variable ENV in data_source_factory.py that stores the environment name read from the ENVIRONMENT environment variable.
- unit tests
refactoring feat: added tests for athena
bvolodarskiy
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.