Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dedicated Protobuf editor #1415

Closed
Motherships opened this issue Jan 19, 2022 · 0 comments · Fixed by #1426
Closed

Add dedicated Protobuf editor #1415

Motherships opened this issue Jan 19, 2022 · 0 comments · Fixed by #1426
Assignees
@NelyDavtyan
Labels
scope/frontend status/accepted An issue which has passed triage and has been accepted type/enhancement En enhancement to an already existing feature
Milestone
0.3.2

Comments

@Motherships
Copy link
Contributor

Is your proposal related to a problem?

Right now we use JSONEditor to edit Protobuf schema
I think dedicated editor will make overall UX better (syntax hightlight etc)

Describe the solution you'd like

We have to implement dedicated Protobuf editor
AceEditor which we use already has mode for protobuf
And we can even make SchemaEditor component to make code clear
Something like this:
image

Describe alternatives you've considered

Alternative is we don't do this and use JSONEditor as we do now

Additional context
@Motherships Motherships added type/enhancement En enhancement to an already existing feature scope/frontend labels Jan 19, 2022
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jan 19, 2022
@provectus provectus deleted a comment from github-actions bot Jan 19, 2022
@Haarolean Haarolean added status/needs-attention Collective discussion is required and removed status/triage Issues pending maintainers triage labels Jan 19, 2022
@Motherships Motherships mentioned this issue Jan 19, 2022
Merged
13 tasks
@Motherships Motherships linked a pull request Jan 20, 2022 that will close this issue
Protobuf schema is not formatted properly #1426
Merged
13 tasks
@Haarolean Haarolean added this to the 0.3.2 milestone Jan 20, 2022
@Haarolean Haarolean added status/accepted An issue which has passed triage and has been accepted redesign and removed status/needs-attention Collective discussion is required labels Jan 20, 2022
@NelyDavtyan NelyDavtyan self-assigned this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NelyDavtyan NelyDavtyan

Labels
scope/frontend status/accepted An issue which has passed triage and has been accepted type/enhancement En enhancement to an already existing feature
Projects
None yet
Milestone
0.3.2
Development

Successfully merging a pull request may close this issue.

Protobuf schema is not formatted properly provectus/kafka-ui
3 participants
@Haarolean @Motherships @NelyDavtyan