Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf schema is not formatted properly #1426

Merged
merged 16 commits into from
Jan 20, 2022
Merged

Protobuf schema is not formatted properly #1426

merged 16 commits into from
Jan 20, 2022

Conversation

NelyDavtyan
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)
Issue #1346
Schema for PROTOBUF type was showing like a string, after changes it's showing in the right way.
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@NelyDavtyan
clusters"s table styles was fixed, added hyphens to breadcrumbs, URP …
def589c 
…is not abbreviated and ISR is abbreviated already and "f0" was changed to 0
@NelyDavtyan
styled component name for cluster table was changed
051df93
@NelyDavtyan
adding tests for clusterwidget cells, adding title for ISR and bringi…
d3c8a6f 
…ng back changes in breadcrumb regarding hyphens
@NelyDavtyan
fixing clusterWidget test
3d7181f
@NelyDavtyan
fixing double scroll issue inside Topics > Messages > Content for lar…
15ce12c 
…ge message content
@NelyDavtyan
bring back last changes
7d10298
@NelyDavtyan
changing styles for scrollbar
6de7ae8
@NelyDavtyan
Merge branch 'master' of https://github.com/provectus/kafka-ui into i…
890665a 
…ssues/1346
@NelyDavtyan
fixing protobuf schema to be formatted correctly
35abd90
@NelyDavtyan
fixing conflicts
4340cb6
@NelyDavtyan
Merge branch 'master' of https://github.com/provectus/kafka-ui into i…
c8f78be 
…ssues/1346
@NelyDavtyan
fixing conflicts
f017bcd
@NelyDavtyan NelyDavtyan self-assigned this Jan 19, 2022
@NelyDavtyan NelyDavtyan changed the title Issues/1346 Protobuf schema is not formatted properly Jan 19, 2022
@NelyDavtyan NelyDavtyan linked an issue Jan 19, 2022 that may be closed by this pull request
protobuf schema is not formatted properly #1346
Closed
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jan 19, 2022
@Motherships
Copy link
Contributor

Fixes #1190

@Motherships
Copy link
Contributor

Motherships commented Jan 19, 2022 •
edited
Loading

It seems it breaks MessageContent height
image

Example how it looks on stand
image

@Haarolean Haarolean added redesign scope/frontend type/bug Something isn't working and removed status/triage Issues pending maintainers triage labels Jan 19, 2022
@Motherships
Copy link
Contributor

Can confirm MessageContent height is fixed

@Motherships
Copy link
Contributor

Resolves #1415

@Motherships Motherships linked an issue Jan 20, 2022 that may be closed by this pull request
Add dedicated Protobuf editor #1415
Closed
@Haarolean Haarolean linked an issue Jan 20, 2022 that may be closed by this pull request
Different appearance of Relevant version for PROTOBUF schema #1190
Closed
@Haarolean Haarolean added the type/enhancement En enhancement to an already existing feature label Jan 20, 2022
@NelyDavtyan NelyDavtyan merged commit 68f1d3e into master Jan 20, 2022
@NelyDavtyan NelyDavtyan deleted the issues/1346 branch January 20, 2022 09:21
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.0% 93.0% Coverage
0.0% 0.0% Duplication

javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
@NelyDavtyan @Haarolean
Protobuf schema is not formatted properly (provectus#1426)
e60ced8 
* clusters"s table styles was fixed, added hyphens to breadcrumbs, URP is not abbreviated and ISR is abbreviated already and "f0" was changed to 0

* styled component name for cluster table was changed

* adding tests for clusterwidget cells, adding title for ISR and bringing back changes in breadcrumb regarding hyphens

* fixing clusterWidget test

* fixing double scroll issue inside Topics > Messages > Content for large message content

* bring back last changes

* changing styles for scrollbar

* fixing protobuf schema to be formatted correctly

* makeing requested changes, JSONEditor renamed to Editor,fixed schema edit and versions

* rename JSONViewer to EditorViewer

Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hurenka Hurenka Hurenka approved these changes

@Motherships Motherships Motherships approved these changes

Assignees

@NelyDavtyan NelyDavtyan

Labels
scope/frontend type/bug Something isn't working type/enhancement En enhancement to an already existing feature
Projects
None yet
Milestone
No milestone
4 participants
@NelyDavtyan @Motherships @Hurenka @Haarolean