Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make message timestamp format configurable #2163

Open
Haarolean opened this issue Jun 14, 2022 · 5 comments · Fixed by #2277 or #2590
Open

Make message timestamp format configurable #2163

Haarolean opened this issue Jun 14, 2022 · 5 comments · Fixed by #2277 or #2590
Labels
good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted status/needs-attention Collective discussion is required type/enhancement En enhancement to an already existing feature

Comments

@Haarolean
Copy link
Contributor

Haarolean commented Jun 14, 2022

We changed default date format as requested in #2162.

We need the datetime format configurable on the frontend for the ones who prefer the US format or anything else.

@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature good first issue Up for grabs scope/backend scope/frontend status/accepted An issue which has passed triage and has been accepted status/needs-attention Collective discussion is required labels Jun 14, 2022
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jun 14, 2022
@Haarolean Haarolean removed the status/triage Issues pending maintainers triage label Jun 14, 2022
@Sergiy-provectus Sergiy-provectus self-assigned this Jul 8, 2022
@Haarolean Haarolean linked a pull request Jul 18, 2022 that will close this issue
@Haarolean Haarolean reopened this Aug 30, 2022
@Haarolean Haarolean added this to the 0.5 milestone Sep 15, 2022
@Haarolean
Copy link
Contributor Author

frontend requirements: #2566

@sarkarshuvojit
Copy link

Hey @Haarolean I would like to take this up. Do we want to give the users a limited set of predefined formats, or do we want to give them full flexibility to input a date format which we can use to safely parse any date to?

@sarkarshuvojit
Copy link

I think giving them a limited set of formats will be better as we will reduce uncertainty at runtime. And, that set of formats can come from a standard set of formats used around the globe.

We can also do a hybrid, where we provide a few standard formats & also let the user input their own format as text input. To reduce complexity we can parse and validate that date format and provide an appropriate error to the user.

@Haarolean
Copy link
Contributor Author

Discussed on discord: needs discussion

there are a few problems with this one:

  1. we don't have a design solution for that one, yet
  2. Not sure that we'd need this any longer since we implemented a dynamic timestamp format depending on the users' locale (US vs non-US), which looks like it's enough for now

@Haarolean Haarolean added the status/needs-attention Collective discussion is required label Apr 7, 2023
@danielgafni
Copy link

It would be useful if more granular (sub-second, like milliseconds) timestamp information could be displayed too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted status/needs-attention Collective discussion is required type/enhancement En enhancement to an already existing feature
Projects
None yet
5 participants