-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format dates in a single place, Display build date instead of full commit hash in version info #2590
Conversation
Custom deployment will be available at http://pr2590.internal.kafka-ui.provectus.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow my review comments and fix linting issues
kafka-ui-react-app/src/components/Topics/Topic/Messages/Message.tsx
Outdated
Show resolved
Hide resolved
kafka-ui-react-app/src/components/Topics/Topic/Messages/Message.tsx
Outdated
Show resolved
Hide resolved
Custom deployment removed |
kafka-ui-react-app/src/components/contexts/TimeFormatContext.tsx
Outdated
Show resolved
Hide resolved
df25b8d
to
24f78e1
Compare
Pull request is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom deployment removed |
4391859
to
784021a
Compare
is ready |
kafka-ui-react-app/src/components/Version/__tests__/Version.spec.tsx
Outdated
Show resolved
Hide resolved
kafka-ui-react-app/src/components/contexts/GlobalSettingsContext.tsx
Outdated
Show resolved
Hide resolved
3dbd2a0
to
9250003
Compare
72e9710
to
4f96c37
Compare
Kudos, SonarCloud Quality Gate passed! |
…mmit hash in version info (provectus#2590) * message * if tag contains -SNAPSHOT - display formatted timestamp * create Time format context * fix pull request commits * change pull request commits * add fetchTimeFormat function * add fetchTimeFormat function * chnage test run * fix testing error * covered global context with tests * removed unused import statement * fixed smell * pull master * fixed code smeils * covered Version component, hooks with tests, fixed code review comments * converted outdated to boolean * remove tag condition from return
…mmit hash in version info (#2590) * message * if tag contains -SNAPSHOT - display formatted timestamp * create Time format context * fix pull request commits * change pull request commits * add fetchTimeFormat function * add fetchTimeFormat function * chnage test run * fix testing error * covered global context with tests * removed unused import statement * fixed smell * pull master * fixed code smeils * covered Version component, hooks with tests, fixed code review comments * converted outdated to boolean * remove tag condition from return
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)