Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format dates in a single place, Display build date instead of full commit hash in version info #2590

Merged
merged 21 commits into from
Sep 28, 2022

Conversation

habrahamyanpro
Copy link
Contributor

@habrahamyanpro habrahamyanpro commented Sep 15, 2022

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@habrahamyanpro habrahamyanpro requested a review from a team as a code owner September 15, 2022 12:04
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Sep 15, 2022
@habrahamyanpro habrahamyanpro changed the title message Format dates in a single place #2566 Sep 15, 2022
@habrahamyanpro habrahamyanpro changed the title Format dates in a single place #2566 Format dates in a single place, Display build date instead of full commit hash in version info Sep 15, 2022
@habrahamyanpro habrahamyanpro self-assigned this Sep 15, 2022
@workshur workshur added status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. and removed status/triage Issues pending maintainers triage labels Sep 15, 2022
@github-actions
Copy link

Custom deployment will be available at http://pr2590.internal.kafka-ui.provectus.io

Copy link
Member

@workshur workshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow my review comments and fix linting issues

@workshur workshur removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Sep 15, 2022
@github-actions
Copy link

Custom deployment removed

@habrahamyanpro
Copy link
Contributor Author

Pull request is ready

@Haarolean Haarolean self-requested a review September 16, 2022 19:32
Copy link
Contributor

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Date format used currently is a weird one:
    image
  2. There are no calls to /api/info/timestampformat API endpoint as far as I see.

@workshur workshur added the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Sep 19, 2022
@workshur workshur removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Sep 20, 2022
@github-actions
Copy link

Custom deployment removed

@habrahamyanpro
Copy link
Contributor Author

is ready

@habrahamyanpro habrahamyanpro linked an issue Sep 22, 2022 that may be closed by this pull request
@workshur workshur self-requested a review September 27, 2022 14:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.8% 94.8% Coverage
0.0% 0.0% Duplication

@workshur workshur self-requested a review September 28, 2022 11:22
@workshur workshur merged commit eb03a12 into master Sep 28, 2022
@workshur workshur deleted the feat/format-dates-2566 branch September 28, 2022 11:23
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
…mmit hash in version info (provectus#2590)

* message

* if tag contains -SNAPSHOT - display formatted timestamp

* create Time format context

* fix pull request commits

* change pull request commits

* add fetchTimeFormat function

* add fetchTimeFormat function

* chnage test run

* fix testing error

* covered global context with tests

* removed unused import statement

* fixed smell

* pull master

* fixed code smeils

* covered Version component, hooks with tests, fixed code review comments

* converted outdated to boolean

* remove tag condition from return
@Haarolean Haarolean added the type/enhancement En enhancement to an already existing feature label Dec 9, 2022
Narekmat pushed a commit that referenced this pull request Dec 12, 2022
…mmit hash in version info (#2590)

* message

* if tag contains -SNAPSHOT - display formatted timestamp

* create Time format context

* fix pull request commits

* change pull request commits

* add fetchTimeFormat function

* add fetchTimeFormat function

* chnage test run

* fix testing error

* covered global context with tests

* removed unused import statement

* fixed smell

* pull master

* fixed code smeils

* covered Version component, hooks with tests, fixed code review comments

* converted outdated to boolean

* remove tag condition from return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend type/enhancement En enhancement to an already existing feature
Projects
None yet
3 participants