Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated topic URP status color. #1336

Merged
merged 6 commits into from
Jan 18, 2022
Merged

Updated topic URP status color. #1336

merged 6 commits into from
Jan 18, 2022

Conversation

NelyDavtyan
Copy link
Contributor

@NelyDavtyan NelyDavtyan commented Dec 29, 2021 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)
Issues #1268
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@Haarolean Haarolean linked an issue Dec 29, 2021 that may be closed by this pull request
Topic stats look strange #1268
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@workshur
Copy link
Member

@NelyDavtyan Good job!

@workshur workshur requested a review from Motherships January 17, 2022 08:10
@Hurenka Hurenka dismissed their stale review January 17, 2022 14:32

Decided to change this in another issue

@NelyDavtyan NelyDavtyan merged commit bdf01e4 into master Jan 18, 2022
@NelyDavtyan NelyDavtyan deleted the issues/1268 branch January 18, 2022 15:04
@Haarolean Haarolean added scope/frontend type/bug Something isn't working labels Jan 19, 2022
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
@NelyDavtyan
Updated topic URP status color. (provectus#1336)
95d6ee2 
* Updated topic URP status color.

* Small fix.

* Added test for circular-alert.

* Added test for topic detail overview.

* Fixed name.

* Updated test for topic detail overview.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workshur workshur workshur approved these changes

@Hurenka Hurenka Hurenka approved these changes

@Motherships Motherships Motherships approved these changes

Assignees

@NelyDavtyan NelyDavtyan

Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topic stats look strange
5 participants
@NelyDavtyan @workshur @Motherships @Hurenka @Haarolean