Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now special characters url are decoded in ReadOnlyModeFilter #1378

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

bystnik
Copy link
Contributor

@bystnik bystnik commented Jan 12, 2022

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there bystnik! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 149 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Haarolean Haarolean requested a review from iliax January 13, 2022 23:23
@Haarolean Haarolean linked an issue Jan 13, 2022 that may be closed by this pull request
@Haarolean Haarolean added scope/backend type/bug Something isn't working labels Jan 13, 2022
@Haarolean Haarolean merged commit 0a7d64d into master Jan 18, 2022
@Haarolean Haarolean deleted the issue-1139 branch January 18, 2022 10:32
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
Co-authored-by: Nikita Bystrov <n.bysterov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad handling of cluster names
3 participants