Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes #1391] Incorrect topic message content type (avro -> json) #1422

Merged
merged 5 commits into from
Jan 19, 2022
Merged

[Fixes #1391] Incorrect topic message content type (avro -> json) #1422

merged 5 commits into from
Jan 19, 2022

Conversation

Motherships
Copy link
Contributor

@Motherships Motherships commented Jan 19, 2022 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?
Nothing particular

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@Motherships Motherships added type/bug Something isn't working scope/frontend labels Jan 19, 2022
@Motherships Motherships self-assigned this Jan 19, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Motherships Motherships merged commit 2d5a8c0 into master Jan 19, 2022
@Motherships Motherships deleted the issues/1391 branch January 19, 2022 14:45
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
@Motherships
[Fixes provectus#1391] Incorrect topic message content type (avro -> …
f3fb2c6 
…json) (provectus#1422)

* Updates MessageContent to use keyFormat and valueFormat data from API

* Changes imports to * from S

* Adds tests verify keyFormat and contentFormat renders correctly

Co-authored-by: Damir Abdulganiev <dabdulganiev@provectus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelyDavtyan NelyDavtyan NelyDavtyan approved these changes

@Hurenka Hurenka Hurenka approved these changes

@workshur workshur workshur approved these changes

Assignees

@Motherships Motherships

Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect topic message content type (avro -> json)
4 participants
@Motherships @workshur @Hurenka @NelyDavtyan