Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolves #1221] Unclear parameters for Consumers` Search. Inconsistency of Search line on Consumers page. #1429

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

Motherships
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?
Nothing

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@Motherships Motherships added type/enhancement En enhancement to an already existing feature scope/frontend redesign labels Jan 19, 2022
@Motherships Motherships self-assigned this Jan 19, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Motherships Motherships merged commit 8639403 into master Jan 20, 2022
@Motherships Motherships deleted the issues/1221 branch January 20, 2022 09:39
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
…nconsistency of Search line on Consumers page. (provectus#1429)

* Changed Search component placeholder

* Updates test

Co-authored-by: Damir Abdulganiev <dabdulganiev@provectus.com>
Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend type/enhancement En enhancement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear parameters for Consumers` Search. Inconsistency of Search line on Consumers page.
5 participants