[Fixes #1410] Edited using colors in styled components using our Theme #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekshut
requested review from
workshur,
NelyDavtyan,
abelgibayev,
GneyHabub,
Hurenka and
Motherships
Motherships
reviewed
Jan 21, 2022
There was a problem hiding this comment.
Seems okay to me
Just some missed uses of Colors and inconsistency in naming
I think you can use as a rule of the thumb this list:
- If I changed file I have to look if I changed all uses of
Colorsobject in this file - If I need to add new property to
themeobject - I have to look how similar properties were named in the past
kafka-ui-react-app/src/components/common/Textbox/Textarea.styled.ts
Outdated
Show resolved
Hide resolved
kafka-ui-react-app/src/components/common/ConfirmationModal/ConfirmationModal.styled.tsx
Show resolved
Hide resolved
NelyDavtyan
reviewed
Jan 21, 2022
...-react-app/src/components/Schemas/Details/__test__/__snapshots__/SchemaVersion.spec.tsx.snap
Show resolved
Hide resolved
Motherships
approved these changes
Jan 21, 2022
NelyDavtyan
approved these changes
Jan 21, 2022
workshur
approved these changes
Jan 21, 2022
|
Kudos, SonarCloud Quality Gate passed! |
javalover123
pushed a commit
to javalover123/kafka-ui
that referenced
this pull request
Dec 7, 2022
… our Theme (provectus#1442) * Edited using colors in syled components * updated snapshots * updated snapshots * edited stylistic mistake Co-authored-by: Oleg Shur <workshur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Added new colors to the Theme pallete, added some new objects yo the Theme
Is there anything you'd like reviewers to focus on?
Updated some test for testing with included ThemeProvider component
How Has This Been Tested? (put an "X" next to an item)
Checklist (put an "X" next to an item, otherwise PR will fail)
Check out Contributing and Code of Conduct