Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-1444: Additional params added to connector restart endpoint to be able to… #1445

Merged
merged 3 commits into from
Jan 21, 2022
Merged

ISSUE-1444: Additional params added to connector restart endpoint to be able to… #1445

merged 3 commits into from
Jan 21, 2022

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Jan 21, 2022 •
edited
Loading

… restart not only connector instance, but all its tasks

  • RESTARTING state added to ConnectorTaskStatus

See https://docs.confluent.io/platform/current/connect/references/restapi.html#post--connectors-(string-name)-restart

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

* Additional params added to connector restart endpoint to be able to…
66c273d 
… restart not only connector instance, but all its tasks

* RESTARTING state added to ConnectorTaskStatus
@iliax iliax linked an issue Jan 21, 2022 that may be closed by this pull request
Connector "Restart All Tasks" button has no effect #1444
Closed
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jan 21, 2022
@iliax iliax requested review from Haarolean and germanosin January 21, 2022 09:53
@Haarolean Haarolean added scope/backend type/bug Something isn't working and removed status/triage Issues pending maintainers triage labels Jan 21, 2022
Haarolean
Haarolean approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do not merge until we rename the button on the frontend

@Haarolean Haarolean added the status/pending Further information is requested label Jan 21, 2022
@iliax iliax requested a review from Haarolean January 21, 2022 12:05
@Haarolean Haarolean removed the status/pending Further information is requested label Jan 21, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 159 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iliax iliax merged commit f85a340 into master Jan 21, 2022
@iliax iliax deleted the ISSUE-1444 branch January 21, 2022 12:24
@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature and removed type/bug Something isn't working labels Apr 22, 2022
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
ISSUE-1444: Additional params added to connector restart endpoint to …
246dd32 
…be able to… (provectus#1445)

* Additional params added to connector restart endpoint to be able to restart not only connector instance, but all its tasks
* RESTARTING state added to ConnectorTaskStatus
* Restart connector button rename

Co-authored-by: iliax <ikuramshin@provectus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haarolean Haarolean Haarolean approved these changes

@germanosin germanosin Awaiting requested review from germanosin

Assignees

@iliax iliax

Labels
scope/backend type/enhancement En enhancement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connector "Restart All Tasks" button has no effect
2 participants
@iliax @Haarolean