-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add labels required by istio #2548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there PatTheSilent! 👋
Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖
We will try to review it soon!
Hey, thanks for the contribution. We'll take a look :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not see any breacking changes, we could merge it
@PatTheSilent thank you! |
This reverts commit 1134ec5.
What changes did you make? (Give an overview)
I've added labels required by istio.
Without these labels istio reports traffic coming from kafka-ui to kafka connect and schema registry with a label
source_app
set tounknown
, which is far from ideal. Visualizations tools like kiali or Grafana dashboards rely on thesource_app
label in istio metrics to present traffic flowing through environments.Oh, and apparently my IDE has corrected some whitespaces. I can remove those if they don't meet your conventions or you don't want them.
Is there anything you'd like reviewers to focus on?
Their happiness and wellbeing.
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
Adding a cute corgi