Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add labels required by istio #2548

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

PatTheSilent
Copy link
Contributor

@PatTheSilent PatTheSilent commented Sep 8, 2022

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
I've added labels required by istio.
Without these labels istio reports traffic coming from kafka-ui to kafka connect and schema registry with a label source_app set to unknown, which is far from ideal. Visualizations tools like kiali or Grafana dashboards rely on the source_app label in istio metrics to present traffic flowing through environments.

Oh, and apparently my IDE has corrected some whitespaces. I can remove those if they don't meet your conventions or you don't want them.

Is there anything you'd like reviewers to focus on?

Their happiness and wellbeing.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
Adding a cute corgi
pembroke-welsh-corgi

@PatTheSilent PatTheSilent requested a review from a team as a code owner September 8, 2022 11:29
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there PatTheSilent! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@Haarolean
Copy link
Contributor

Hey, thanks for the contribution. We'll take a look :)

@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/k8s K8s or helm stuff (really annoying) labels Sep 8, 2022
@Haarolean Haarolean self-assigned this Sep 8, 2022
Copy link
Contributor

@azatsafin azatsafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not see any breacking changes, we could merge it

@Haarolean Haarolean merged commit 1134ec5 into provectus:master Sep 9, 2022
@Haarolean
Copy link
Contributor

@PatTheSilent thank you!

Haarolean added a commit that referenced this pull request Sep 15, 2022
Haarolean added a commit that referenced this pull request Sep 15, 2022
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
Narekmat pushed a commit that referenced this pull request Dec 12, 2022
Narekmat pushed a commit that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/k8s K8s or helm stuff (really annoying) type/enhancement En enhancement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants