Messages V1 Pagination #2862

Mgrdich · 2022-11-01T20:20:15Z

Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
I have added next and prev pagination to the old messages page.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
My changes generate no new warnings (e.g. Sonar is happy)
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

workshur · 2022-11-07T10:43:06Z

@Haarolean, this one is ready for QA

armenuikafka

seems not all messages are displayed within topic, there are 103 messages but displayed only 19. therefore pagination is not right. as we corrected the limitation for each page should be 100

pagination.mov

Mgrdich · 2022-11-16T12:20:54Z

seems not all messages are displayed within topic, there are 103 messages but displayed only 19. therefore pagination is not right. as we corrected the limitation for each page should be 100

pagination.mov

This is an old bug that is not related to the where you navigate to the page from the topic page the url, actually the code does not get updated before the request, once you refresh the page you will see 100 limited element in the messages

But i will see what i can do to fix it , cause the code in that particular is a bit messy. @Haarolean

add minor test in messages table component Add Messages pagination add next feature in the Advanced Filters Messages Table add Back button navigation remove un-necessary code from the messages table minor code refactors to remove unnecessary codes page parameter fix in the query of the advanced Filters minor change in the test file to keep uniformity of the project set default table limit for first request messages v1