Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] Change message timestamp format #3119

Merged
merged 9 commits into from
Dec 23, 2022
Merged

[FE] Change message timestamp format #3119

merged 9 commits into from
Dec 23, 2022

Conversation

Mgrdich
Copy link
Contributor

@Mgrdich Mgrdich commented Dec 22, 2022

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Remove the dayjs library and TimeFormat fetches , and replace with the browser locale.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Mgrdich Mgrdich requested a review from a team as a code owner December 22, 2022 11:46
@Mgrdich Mgrdich self-assigned this Dec 22, 2022
@Mgrdich Mgrdich linked an issue Dec 22, 2022 that may be closed by this pull request
Change message timestamp format #2162
Closed
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Dec 22, 2022
@Mgrdich Mgrdich added type/enhancement En enhancement to an already existing feature scope/frontend labels Dec 22, 2022
@Mgrdich Mgrdich force-pushed the issues/2162_timestamp_format branch from b431769 to db9948f Compare December 22, 2022 18:28
@Haarolean Haarolean added type/feature A new feature status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. and removed status/triage Issues pending maintainers triage type/feature A new feature labels Dec 23, 2022
@github-actions
Copy link

Custom deployment will be available at http://pr3119.internal.kafka-ui.provectus.io

@Haarolean Haarolean added status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. and removed status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. labels Dec 23, 2022
@github-actions
Copy link

Custom deployment removed

@github-actions
Copy link

Custom deployment will be available at http://pr3119.internal.kafka-ui.provectus.io

@Haarolean Haarolean self-requested a review December 23, 2022 12:47
@Haarolean Haarolean changed the title Issues/2162 timestamp format [FE] Change message timestamp format Dec 23, 2022
@Haarolean Haarolean changed the base branch from master to chore/drop-timestamps December 23, 2022 12:48
@Haarolean Haarolean requested a review from a team as a code owner December 23, 2022 12:48
@Haarolean Haarolean requested a review from a team as a code owner December 23, 2022 12:48
@Haarolean Haarolean removed the request for review from a team December 23, 2022 12:49
@Haarolean Haarolean merged commit a4f3888 into chore/drop-timestamps Dec 23, 2022
@Haarolean Haarolean deleted the issues/2162_timestamp_format branch December 23, 2022 12:49
@github-actions
Copy link

Custom deployment removed

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

Haarolean added a commit that referenced this pull request Dec 23, 2022
@Haarolean @Mgrdich
Change message timestamp format (#3113)
027d9b4 
* Drop experimental endpoints

* [FE] Change message timestamp format (#3119)

* remove dayjs from the code base

* remove dayjs library and clean up the hook codes

* minor obsolete fixtures deletion

* minor provider code modifications

* minor provider code modifications

* minor linter code modifications

* minor date local and language code modifications

Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>

* removing timestamp api from the generated sources

Co-authored-by: Mgrdich <46796009+Mgrdich@users.noreply.github.com>
Co-authored-by: Mgrdich <mgotm13@gmail.com>
@Haarolean Haarolean removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

Custom deployment removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-DB88 David-DB88 David-DB88 approved these changes

@Haarolean Haarolean Haarolean approved these changes

@workshur workshur workshur approved these changes

Assignees

@Mgrdich Mgrdich

Labels
scope/frontend type/enhancement En enhancement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change message timestamp format
4 participants
@Mgrdich @workshur @Haarolean @David-DB88