Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Events Hub support fixed #3540

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Azure Events Hub support fixed #3540

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c4fa54
UnknownTopicOrPartitionException error suppressing added when calling…
Mar 23, 2023
9c9cbc0
formatting reverted
Mar 23, 2023
11fc6b8
Merge branch 'master' into ISSUE-2441_azure_fixes
iliax Mar 23, 2023
c2272b3
Merge branch 'master' into ISSUE-2441_azure_fixes
iliax Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/ReactiveAdminClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,17 +212,24 @@ private static Mono<Map<Integer, List<ConfigEntry>>> loadBrokersConfig(AdminClie
.map(brokerId -> new ConfigResource(ConfigResource.Type.BROKER, Integer.toString(brokerId)))
.collect(toList());
return toMono(client.describeConfigs(resources).all())
// some kafka backends (like MSK serverless) do not support broker's configs retrieval,
// in that case InvalidRequestException will be thrown
.onErrorResume(InvalidRequestException.class, th -> {
log.trace("Error while getting broker {} configs", brokerIds, th);
return Mono.just(Map.of());
})
// some kafka backends don't support broker's configs retrieval,
// and throw various exceptions on describeConfigs() call
.onErrorResume(th -> th instanceof InvalidRequestException // MSK Serverless
|| th instanceof UnknownTopicOrPartitionException, // Azure event hub
th -> {
log.trace("Error while getting configs for brokers {}", brokerIds, th);
return Mono.just(Map.of());
})
// there are situations when kafka-ui user has no DESCRIBE_CONFIGS permission on cluster
.onErrorResume(ClusterAuthorizationException.class, th -> {
log.trace("AuthorizationException while getting configs for brokers {}", brokerIds, th);
return Mono.just(Map.of());
})
// catching all remaining exceptions, but logging on WARN level
.onErrorResume(th -> true, th -> {
log.warn("Unexpected error while getting configs for brokers {}", brokerIds, th);
return Mono.just(Map.of());
})
.map(config -> config.entrySet().stream()
.collect(toMap(
c -> Integer.valueOf(c.getKey().name()),
Expand Down