-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update display of key/value format #3117 #3543
Conversation
if this solution is normal, then i will change the test cases |
Custom deployment will be available at http://pr3543.internal.kafka-ui.provectus.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally looks good overall, let's
- rename "Key" and "Value" to "Key Serde" and "Value Serde" respectively
- fix the linter warnings
Custom deployment removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the linter error , 'proto' is assigned a value but never used
...ct-app/src/components/Topics/Topic/Messages/MessageContent/__tests__/MessageContent.spec.tsx
Outdated
Show resolved
Hide resolved
Custom deployment will be available at http://pr3543.internal.kafka-ui.provectus.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@David-DB88 one more nitpick: put the "key" one above the value, basically change the order
good to merge once done
Custom deployment removed |
Kudos, SonarCloud Quality Gate passed! |
What changes did you make? (Give an overview)
added key value format
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)