Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update display of key/value format #3117 #3543

Merged
merged 11 commits into from
Mar 28, 2023

Conversation

David-DB88
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
added key value format
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@David-DB88
Copy link
Contributor Author

David-DB88 commented Mar 23, 2023

if this solution is normal, then i will change the test cases

@David-DB88 David-DB88 marked this pull request as ready for review March 23, 2023 16:57
@David-DB88 David-DB88 requested a review from a team as a code owner March 23, 2023 16:57
@Haarolean Haarolean added the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Mar 23, 2023
@github-actions
Copy link

Custom deployment will be available at http://pr3543.internal.kafka-ui.provectus.io

@Haarolean Haarolean self-requested a review March 24, 2023 07:20
Copy link
Contributor

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally looks good overall, let's

  1. rename "Key" and "Value" to "Key Serde" and "Value Serde" respectively
  2. fix the linter warnings

@Haarolean Haarolean removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Mar 24, 2023
@Haarolean Haarolean linked an issue Mar 24, 2023 that may be closed by this pull request
@github-actions
Copy link

Custom deployment removed

@Haarolean Haarolean added the type/chore Boring stuff, could be refactoring or tech debt label Mar 24, 2023
Copy link
Contributor

@Mgrdich Mgrdich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the linter error , 'proto' is assigned a value but never used

@David-DB88 David-DB88 requested a review from Mgrdich March 27, 2023 13:52
@Haarolean Haarolean added the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Mar 27, 2023
@github-actions
Copy link

Custom deployment will be available at http://pr3543.internal.kafka-ui.provectus.io

@Haarolean Haarolean self-requested a review March 27, 2023 18:20
Copy link
Contributor

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@David-DB88 one more nitpick: put the "key" one above the value, basically change the order
image
good to merge once done

@Haarolean Haarolean removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Mar 27, 2023
@github-actions
Copy link

Custom deployment removed

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@Haarolean Haarolean self-requested a review March 28, 2023 12:12
@Haarolean Haarolean merged commit 4623f8d into master Mar 28, 2023
@Haarolean Haarolean deleted the Update_display_of_key/value_format_#3117 branch March 28, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] Update display of key/value format
3 participants