-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a RBAC authorities extractor to support subject-level role matching #3979
Conversation
...rc/main/java/com/provectus/kafka/ui/service/rbac/extractor/RbacLdapAuthoritiesExtractor.java
Outdated
Show resolved
Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/config/auth/LdapSecurityConfig.java
Show resolved
Hide resolved
...rc/main/java/com/provectus/kafka/ui/service/rbac/extractor/RbacLdapAuthoritiesExtractor.java
Outdated
Show resolved
Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/config/auth/LdapSecurityConfig.java
Outdated
Show resolved
Hide resolved
…el role matching. Expand search with group search filter and subtree search flag
I found as if we define group-role-attribute not equal cn then we will got an exception.
I suggest solution as: public DefaultLdapAuthoritiesPopulator ldapAuthoritiesExtractor(ApplicationContext context, BaseLdapPathContextSource contextSource, AccessControlService acs)
Change RbacLdapAuthoritiesExtractor private Set getRoles(String userDn, String username)
|
What changes did you make? (Give an overview)
Before that, matching could be done just on the role name level:
Now it's aligned more with the behavior present at other extractors:
The previous matching stays intact as well.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)