-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protobuf raw message deserializer #4041
Merged
iliax
merged 6 commits into
provectus:master
from
kostasdizas:feature/protobuf-raw-serde
Aug 11, 2023
Merged
Add protobuf raw message deserializer #4041
iliax
merged 6 commits into
provectus:master
from
kostasdizas:feature/protobuf-raw-serde
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haarolean
added
type/enhancement
En enhancement to an already existing feature
scope/backend
labels
Jul 18, 2023
iliax
suggested changes
Jul 25, 2023
kafka-ui-api/src/main/java/com/provectus/kafka/ui/serdes/builtin/ProtobufRawSerde.java
Outdated
Show resolved
Hide resolved
kafka-ui-api/src/test/java/com/provectus/kafka/ui/serdes/builtin/ProtobufRawSerdeTest.java
Outdated
Show resolved
Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/serdes/builtin/ProtobufRawSerde.java
Show resolved
Hide resolved
@kostasdizas, thank you for your contribution! I left couple comments and suggestions - please take a look. |
iliax
suggested changes
Aug 5, 2023
kafka-ui-api/src/test/java/com/provectus/kafka/ui/serdes/builtin/ProtobufRawSerdeTest.java
Outdated
Show resolved
Hide resolved
iliax
added
status/feature_testing
This branch/PR has been deployed to a separate PRIVATE environment for testing.
and removed
status/feature_testing
This branch/PR has been deployed to a separate PRIVATE environment for testing.
labels
Aug 5, 2023
Make schemas more consistent
iliax
approved these changes
Aug 10, 2023
kafka-ui-api/src/main/java/com/provectus/kafka/ui/serdes/builtin/ProtobufRawSerde.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Implemented a Protobuf Raw deserialiser that works like
protoc --decode_raw
. This is a no config alternative to the existing ProtobufFileSerdeIs there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)