Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Respect system proxy settings in WebClient #4042

Merged

Conversation

Khrol
Copy link
Contributor

@Khrol Khrol commented Jul 18, 2023

HTTP(S) proxy settings are applied only in some specific cases when configureSsl is called with some non-null params. They should be always used.

GithubReleaseInfo is not executed properly in our environment.

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)

Checked this branch on our production env:
Screenshot 2023-07-18 at 10 33 32

  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

HTTP(S) proxy settings are applied only in some specific cases when `configureSsl` is called with some non-null params.
They should be always used.
@Khrol Khrol marked this pull request as ready for review July 18, 2023 05:59
@Khrol Khrol requested a review from a team as a code owner July 18, 2023 05:59
@Khrol Khrol requested a review from Haarolean July 18, 2023 06:46
@Haarolean Haarolean self-assigned this Jul 18, 2023
@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/backend labels Jul 18, 2023
@Haarolean Haarolean added this to the 0.8 milestone Jul 18, 2023
@Haarolean Haarolean changed the title Respect system proxy settings in WebClient BE: Respect system proxy settings in WebClient Jul 18, 2023
@Haarolean Haarolean enabled auto-merge (squash) July 18, 2023 07:12
@Haarolean Haarolean merged commit ca2d53f into provectus:master Jul 24, 2023
@Khrol Khrol deleted the bugfix/always_respect_proxy_settings branch September 22, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/enhancement En enhancement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants