Implement a mechanism to skip SSL verification #4083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haarolean
added
type/enhancement
|
Image published at public.ecr.aws/provectus/kafka-ui-custom-build:4083 |
iliax
suggested changes
Aug 3, 2023
kafka-ui-api/src/main/java/com/provectus/kafka/ui/util/InsecureSslEngineFactory.java
Outdated
Show resolved
Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/util/InsecureSslEngineFactory.java
Outdated
Show resolved
Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/util/InsecureSslEngineFactory.java
Outdated
Show resolved
Hide resolved
Comment on lines
17
to
35
| if (truststoreConfig == null) { | ||
| return; | ||
| } | ||
|
|
||
| if (!truststoreConfig.isVerifySsl()) { | ||
| sink.put(SSL_ENGINE_FACTORY_CLASS_CONFIG, InsecureSslEngineFactory.class); | ||
| return; | ||
| } | ||
|
|
||
| if (truststoreConfig.getTruststoreLocation() == null) { | ||
| return; | ||
| } | ||
|
|
||
| sink.put(SslConfigs.SSL_TRUSTSTORE_LOCATION_CONFIG, truststoreConfig.getTruststoreLocation()); | ||
|
|
||
| if (truststoreConfig.getTruststorePassword() != null) { | ||
| sink.put(SslConfigs.SSL_TRUSTSTORE_PASSWORD_CONFIG, truststoreConfig.getTruststorePassword()); | ||
| } | ||
| } |
There was a problem hiding this comment.
lets maybe avoid extensive spaces usage here
iliax
suggested changes
Aug 3, 2023
| @@ -101,6 +109,16 @@ public static class SchemaRegistryAuth { | |||
| public static class TruststoreConfig { | |||
| String truststoreLocation; | |||
| String truststorePassword; | |||
| boolean verifySsl = true; | |||
There was a problem hiding this comment.
we also need to add property to kafka-ui-api.yaml
|
Image published at public.ecr.aws/provectus/kafka-ui-custom-build:4083 |
|
Image published at public.ecr.aws/provectus/kafka-ui-custom-build:4083 |
iliax
suggested changes
Aug 24, 2023
Comment on lines
+19
to
+21
| if (truststoreConfig.getTruststoreLocation() == null) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
what if verifySsl set to false ? Looks like truststoreConfig.isVerifySsl() check should go before this..
Comment on lines
+105
to
+114
| @SneakyThrows | ||
| public WebClientConfigurator configureNoSsl() { | ||
| var contextBuilder = SslContextBuilder.forClient(); | ||
| contextBuilder.trustManager(InsecureTrustManagerFactory.INSTANCE); | ||
|
|
||
| SslContext context = contextBuilder.build(); | ||
|
|
||
| httpClient = httpClient.secure(t -> t.sslContext(context)); | ||
| return this; | ||
| } |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Closes #4082
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)