Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBAC: Implement roles by github teams #4093

Merged
merged 5 commits into from
Aug 7, 2023
Merged

RBAC: Implement roles by github teams #4093

merged 5 commits into from
Aug 7, 2023

Conversation

Haarolean
Copy link
Contributor

@Haarolean Haarolean commented Aug 4, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Closes #2751

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/backend area/rbac labels Aug 4, 2023
@Haarolean Haarolean self-assigned this Aug 4, 2023
@Haarolean Haarolean requested a review from a team as a code owner August 4, 2023 13:59
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Image published at public.ecr.aws/provectus/kafka-ui-custom-build:4093

@Haarolean Haarolean requested a review from iliax August 7, 2023 14:03
@Haarolean Haarolean enabled auto-merge (squash) August 7, 2023 14:13
@Haarolean Haarolean disabled auto-merge August 7, 2023 15:01
@Haarolean Haarolean enabled auto-merge (squash) August 7, 2023 15:01
@Haarolean Haarolean disabled auto-merge August 7, 2023 15:01
@Haarolean Haarolean merged commit 150fc21 into master Aug 7, 2023
8 checks passed
@Haarolean Haarolean deleted the issues/2751 branch August 7, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RBAC: Support github teams
2 participants