Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Refactor SchemaRegistry serialization logic #4116

Merged
merged 8 commits into from
Aug 30, 2023

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Aug 14, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixes #4173

SchemaRegistry serialization logic moved to one class, manual serializers creation removed

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@iliax iliax requested a review from a team as a code owner August 14, 2023 13:26
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Aug 14, 2023
@iliax iliax changed the title SchemaRegistry serialisation logic refactored SchemaRegistry serialization logic refactored Aug 14, 2023
@Haarolean Haarolean added scope/backend type/refactoring and removed status/triage Issues pending maintainers triage labels Aug 30, 2023
@Haarolean Haarolean changed the title SchemaRegistry serialization logic refactored BE: Refactor SchemaRegistry serialization logic Aug 30, 2023
@Haarolean Haarolean merged commit b0583a3 into master Aug 30, 2023
@Haarolean Haarolean deleted the DISCUSSION-4109_sr_serde_serialize branch August 30, 2023 08:39
@Haarolean Haarolean added type/bug Something isn't working and removed type/refactoring labels Aug 30, 2023
gimral pushed a commit to gimral/kafka-ui that referenced this pull request Feb 23, 2024
Co-authored-by: iliax <ikuramshin@provectus.com>
Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serde Issue with Custom Schema Registry Naming
2 participants