Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Use HTTP GET for basic auth #4135

Merged
merged 1 commit into from
Aug 18, 2023
Merged

BE: Use HTTP GET for basic auth #4135

merged 1 commit into from
Aug 18, 2023

Conversation

Haarolean
Copy link
Contributor

@Haarolean Haarolean commented Aug 18, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixes #4127
Spring does use HTTP GET for OAuth and HTTP POST for login_form for some reason.
Our frontend does use GET and the OAuth filter is hardcoded, so replacing basic to GET

LogoutPageGeneratingWebFilter
LogoutWebFilter

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean self-assigned this Aug 18, 2023
@Haarolean Haarolean requested a review from a team as a code owner August 18, 2023 07:14
@Haarolean Haarolean enabled auto-merge (squash) August 18, 2023 07:14
@Haarolean Haarolean merged commit bdbbdcc into master Aug 18, 2023
25 checks passed
@Haarolean Haarolean deleted the issues/4127 branch August 18, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic auth: Logout returns HTTP 404
2 participants